Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] paint format: copy conditional formats #5124

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Oct 23, 2024

Description

The paint format tool should also copy the conditional formats of the source cells.

Task: 4226853

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5054

The paint format tool should also copy the conditional formats of the
source cells.

Task: 4226853
X-original-commit: 4f2950a
@robodoo
Copy link
Collaborator

robodoo commented Oct 23, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Oct 23, 2024

@hokolomopo @LucasLefevre this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@robodoo r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@LucasLefevre
Copy link
Collaborator

LucasLefevre commented Oct 23, 2024 via email

robodoo pushed a commit that referenced this pull request Oct 23, 2024
The paint format tool should also copy the conditional formats of the
source cells.

closes #5124

Task: 4226853
X-original-commit: 4f2950a
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
@robodoo robodoo closed this Oct 23, 2024
@robodoo robodoo added the 18.1 label Oct 23, 2024
@fw-bot fw-bot deleted the master-18.0-paint-format-cf-adrm-4o2k-fw branch November 6, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants