[FW][FIX] test: skipped test in renderer_plugin.test.ts
#5123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test was skipped in `renderer_plugin.test.ts` because it didn't contain code instructions, but it contained a callback with those instructions. And the callback was never called. The test was also wrong: it forgot to add `MIN_CELL_TEXT_MARGIN` to the width of the text, and to resize the column to make the text overflow. Task: 4276968 X-original-commit: a36121f
|
|
|
@hokolomopo @pro-odoo this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Oct 23, 2024
A test was skipped in `renderer_plugin.test.ts` because it didn't contain code instructions, but it contained a callback with those instructions. And the callback was never called. The test was also wrong: it forgot to add `MIN_CELL_TEXT_MARGIN` to the width of the text, and to resize the column to make the text overflow. closes #5123 Task: 4276968 X-original-commit: a36121f Signed-off-by: Adrien Minne (adrm) <[email protected]> Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A test was skipped in
renderer_plugin.test.tsbecause it didn't contain code instructions, but it contained a callback with those instructions. And the callback was never called.This commit unskips the test and fixes it, it was wrong because it was forgetting to add
MIN_CELL_TEXT_MARGINto the width of the text.Task: 4276968
review checklist
Forward-Port-Of: #5120
Forward-Port-Of: #5116