[FW][FIX] chart: avoid overlapping values on charts #5109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@hokolomopo @LucasLefevre cherrypicking of pull request #5099 failed. stdout: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
The option "Show Values" on charts could lead to overlapping texts in the chart, which was quite ugly. This commit improve the behaviour or the value labels: - prevent overlapping value labels on stacked charts - the bar chart value labels are now in the middle of the bar - the value labels have now the same color as the dataset - prevent value labels from going outside of the chart Code-wise, the commit totally splits the handling of bar and horizontal bar charts. It make the code slightly longer, but avoid having to write a ternary for each computation of x/y position, which ultimately makes the code more readable. Task: 4207889 X-original-commit: 75906d4
hokolomopo
force-pushed
the
18.0-saas-17.4-chart-show-values-adrm-y9DY-fw
branch
from
b143e44 to
c1c064f
Compare
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The option "Show Values" on charts could lead to overlapping texts in the chart, which was quite ugly.
This commit improve the behaviour or the value labels:
Code-wise, the commit totally splits the handling of bar and horizontal bar charts. It make the code slightly longer, but avoid having to write a ternary for each computation of x/y position, which ultimately makes the code more readable.
Task: 4207889
review checklist
Forward-Port-Of: #5099