Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] pivot: date time measures are not supported #5060

Closed
wants to merge 1 commit into from
Closed

[FIX] pivot: date time measures are not supported #5060

wants to merge 1 commit into from

Conversation

LucasLefevre
Copy link
Collaborator

Description:

Steps to reproduce:

  • add a list of data in a spreadsheet, with at least one datetime field
  • add a pivot based on this range
  • add the data field as a measure => boom

Since 8421a73, all "date" fields are now "datetime".

Task: 4241036

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@LucasLefevre
[FIX] pivot: date time measures are not supported
00c247f 
Steps to reproduce:

- add a list of data in a spreadsheet, with at least one datetime field
- add a pivot based on this range
- add the data field as a measure
=> boom

Since 8421a73, all "date" fields are now "datetime".

Task: 4241036
@robodoo
Copy link
Collaborator

robodoo commented Oct 8, 2024

Pull request status dashboard

pro-odoo
pro-odoo approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to ignore my comment

tests/pivots/spreadsheet_pivot/spreadsheet_pivot_side_panel.test.ts Show resolved Hide resolved
@pro-odoo
Copy link
Collaborator

pro-odoo commented Oct 9, 2024

robodoo r+

@robodoo robodoo closed this in 2a83a3e Oct 9, 2024
@fw-bot fw-bot mentioned this pull request Oct 9, 2024
Closed
14 tasks
@fw-bot fw-bot deleted the 18.0-pivot-datetime-not-supported-lul branch October 23, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pro-odoo pro-odoo pro-odoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucasLefevre @robodoo @pro-odoo