[FIX] conditional format: huge revisions on copy/paste cf #5059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
force-pushed
the
18.0-copy-cf-revision-adrm
branch
from
1a9c89e to
96e8ea6
Compare
|
The commit title should refer to clipboard and not just CF since you also fix data validations. Also this seems to be the root cause why we have a weird order of clipboard handlers https://github.com/odoo/o-spreadsheet/blob/18.0/src/clipboard_handlers/index.ts#L23-L24. So might be worth backport this to saas-17.2 and change the handler order at the same time? |
hokolomopo
force-pushed
the
18.0-copy-cf-revision-adrm
branch
from
96e8ea6 to
8c69f49
Compare
When copy/pasting a conditional format, the revision had one ADD_CONDITIONAL_FORMAT command per copied cell. That lead to huge revisions if, for example, a whole column with a CF was copied. Now the revision only has a single ADD_CONDITIONAL_FORMAT command per modified CF. The exact same work was done for data validation rules. Benchmark: ------------------- Copy/paste a column of 100 cells with a CF: Before: 46.6KB revision After: 526B revision (divided by 88!) Task: 4240668
hokolomopo
force-pushed
the
18.0-copy-cf-revision-adrm
branch
from
8c69f49 to
f28d234
Compare
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When copy/pasting a conditional format, the revision had one ADD_CONDITIONAL_FORMAT command per copied cell. That lead to huge revisions if, for example, a whole column with a CF was copied.
Now the revision only has a single ADD_CONDITIONAL_FORMAT command per modified CF.
The exact same work was done for data validation rules.
Benchmark:
Copy/paste a column of 100 cells with a CF:
Before: 46.6KB revision
After: 526B revision (divided by 88!)
Task: 4240668
review checklist