Master f2 composer rar #5012
Closed
Master f2 composer rar #5012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rrahir
force-pushed
the
master-f2-composer-rar
branch
3 times, most recently
from
35c3cb4 to
7155c67
Compare
hokolomopo
reviewed
Sep 23, 2024
| } | ||
| } | ||
|
|
||
| private captureSelection(zone: Zone) { |
There was a problem hiding this comment.
the helper could also be used in the constructor
rrahir
force-pushed
the
master-f2-composer-rar
branch
from
7155c67 to
01747c5
Compare
| color: this.rangeColor(xc, sheetName) || "#000", | ||
| class: | ||
| tokenAtCursor === token && this.props.composerStore.editionMode === "selecting" | ||
| ? referenceSelectedClass |
There was a problem hiding this comment.
we could use the bootstap class text-decoration-underline directly here and remove the constant and the additional css
There was a problem hiding this comment.
The first and third comments from Adrien are resolved but nothing changed.
Definitely a miss on my hand, I'm positive I removed them ><
There was a problem hiding this comment.
@LucasLefevre Fixed the comments (they were outdated) and added the BS class
Currently, the only way to select a range in a formula is to write some
text such that the next argument could be a range (e.g. write '=sum(').
If you edit an existing formula, you need to delete a range argument in
order to 'activate' the range selection mode. While you can use the
graphical tool to move the range around, it can be bothersome to find
which range is where and then having to move it around.
This revision adds the possibility to switch to a range selection mode
when the cursor is on a reference by pressing F2. This allows the user
to click on a range in the composer, switch to 'selecting' mode and then
cllick on another range to replace the current one.
Pressing the shortcut again will switch back to 'editing' mode which can
be helpful to quickly edit formulas.
Task: 4105364
rrahir
force-pushed
the
master-f2-composer-rar
branch
from
01747c5 to
c62882c
Compare
robodoo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Currently, the only way to select a range in a formula is to write some
text such that the next argument could be a range (e.g. write '=sum(').
If you edit an existing formula, you need to delete a range argument in
order to 'activate' the range selection mode. While you can use the
graphical tool to move the range around, it can be bothersome to find
which range is where and then having to move it around.
This revision adds the possibility to switch to a range selection mode
when the cursor is on a reference by pressing F2. This allows the user
to click on a range in the composer, switch to 'selecting' mode and then
cllick on another range to replace the current one.
Pressing the shortcut again will switch back to 'editing' mode which can
be helpful to quickly edit formulas.
closes #5012
Task: 4105364
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist