[FIX] pivot: divergent collaborative duplicated pivot name #5010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Currently, if two users are connected to the same spreadsheet, both have different languages and one of them duplicates a pivot: the spreadsheet states have diverged because `_t(...)` gives two different results on both sides. Note that the command should ideally be upgraded with a script, but it's not possible to get the original pivot name on the upgrade platform. Task: 4199949
LucasLefevre
force-pushed
the
saas-17.4-divergent-duplicated-pivot-name-lul
branch
from
0931f0b to
c74549f
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Oct 11, 2024
Currently, if two users are connected to the same spreadsheet, both have different languages and one of them duplicates a pivot: the spreadsheet states have diverged because `_t(...)` gives two different results on both sides. Note that the command should ideally be upgraded with a script, but it's not possible to get the original pivot name on the upgrade platform. closes #5010 Task: 4199949 Signed-off-by: Rémi Rahir (rar) <[email protected]>
This was referenced Oct 11, 2024
rrahir
added a commit
that referenced
this pull request
Oct 14, 2024
Similar issue to the one raised in #5010. If 2 userrs with different languages (i.e. different translation schemes), importing a sheet data without a name could result in different outcomes for both users. Currently, this is not an issue because the sheet data are 'fixed' upstream by the migration mecanism but this might change/disappear in the future. Task: 0
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Oct 14, 2024
Similar issue to the one raised in #5010. If 2 userrs with different languages (i.e. different translation schemes), importing a sheet data without a name could result in different outcomes for both users. Currently, this is not an issue because the sheet data are 'fixed' upstream by the migration mecanism but this might change/disappear in the future. closes #5090 Task: 0 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Currently, if two users are connected to the same spreadsheet, both have
different languages and one of them duplicates a pivot: the spreadsheet
states have diverged because
_t(...)gives two different results on bothsides.
Note that the command should ideally be upgraded with a script, but it's
not possible to get the original pivot name on the upgrade platform.
Task: 4199949
review checklist