Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] table: update table style on header group removal #4995

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Sep 17, 2024

Description

The table styles were not updated when a header group was removed, because UNGROUP_HEADERS wasn't handled.

Task: 4081345

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4973

@robodoo
Copy link
Collaborator

robodoo commented Sep 17, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Sep 17, 2024

@hokolomopo @LucasLefevre cherrypicking of pull request #4973 failed.

stdout:

Auto-merging src/plugins/ui_feature/table_computed_style.ts
CONFLICT (content): Merge conflict in src/plugins/ui_feature/table_computed_style.ts
Auto-merging src/plugins/ui_stateful/filter_evaluation.ts
Auto-merging tests/table/table_computed_style_plugin.test.ts
CONFLICT (content): Merge conflict in tests/table/table_computed_style_plugin.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

The table styles were not updated when a header group was removed,
because UNGROUP_HEADERS wasn't handled.

Task: 4081345
X-original-commit: b57230f
@hokolomopo hokolomopo force-pushed the saas-17.4-saas-17.2-table-style-header-groups-adrm-M_ql-fw branch from 077d902 to 7cd9588 Compare September 18, 2024 06:02
@hokolomopo
Copy link
Contributor

@robodoo r+

@robodoo robodoo closed this in 0ddac1b Sep 18, 2024
@fw-bot fw-bot deleted the saas-17.4-saas-17.2-table-style-header-groups-adrm-M_ql-fw branch October 2, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants