[FIX] export: Fix default style ignored at export #4979
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
reviewed
Sep 16, 2024
| @@ -162,7 +162,7 @@ export const DEFAULT_STYLE = { | |||
| underline: false, | |||
| fontSize: 10, | |||
| fillColor: "", | |||
| textColor: "#000000", | |||
There was a problem hiding this comment.
Maybe add a random test ? :)
The default style values ignored at export were targetting the font color black (#000000) as the default value. However, the default value is the simple absence of value (or rather an empty string) as we should be able to differentiate it from a choice from the user to set the font color to black (e.g. when the cell is also receiving its style from a CF or a table). Task: 4178743
rrahir
force-pushed
the
17.0-fix-default-style-export-rar
branch
from
7e4f85c to
94f5231
Compare
robodoo
pushed a commit
that referenced
this pull request
Sep 20, 2024
The default style values ignored at export were targetting the font color black (#000000) as the default value. However, the default value is the simple absence of value (or rather an empty string) as we should be able to differentiate it from a choice from the user to set the font color to black (e.g. when the cell is also receiving its style from a CF or a table). closes #4979 Task: 4178743 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default style values ignored at export were targetting the font color black (#000000) as the default value. However, the default value is the simple absence of value (or rather an empty string) as we should be able to differentiate it from a choice from the user to set the font color to black (e.g. when the cell is also receiving its style from a CF or a table).
Task: 4178743
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist