-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] pivot: add indentation to row headers #4961
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hokolomopo
force-pushed
the
master-format-repeat-char-adrm
branch
from
September 10, 2024 09:12
02fce1c
to
b24c13d
Compare
LucasLefevre
approved these changes
Sep 16, 2024
hokolomopo
force-pushed
the
master-format-repeat-char-adrm
branch
from
September 16, 2024 12:39
b24c13d
to
a259d01
Compare
This commit adds the handling of the `*` asterisk character in the format, which repeats the character that comes after it enough times to fill the column. The asterisk is ignored in `cell.formattedValue`, and the character is only repeated if the `formatValue` helper is given a `width` parameter, which we now do only in the grid renderer. The commit also adds this new format feature to the accounting format, to match the behaviour of the other spreadsheet applications. Task: 3965246
This commit adds indentation to row headers in the pivot table, based on the depth of the groupBy. Task: 3965246
hokolomopo
force-pushed
the
master-format-repeat-char-adrm
branch
from
September 17, 2024 11:46
a259d01
to
9777e59
Compare
LucasLefevre
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robodoo rebase-ff r+
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Sep 17, 2024
This commit adds the handling of the `*` asterisk character in the format, which repeats the character that comes after it enough times to fill the column. The asterisk is ignored in `cell.formattedValue`, and the character is only repeated if the `formatValue` helper is given a `width` parameter, which we now do only in the grid renderer. The commit also adds this new format feature to the accounting format, to match the behaviour of the other spreadsheet applications. Task: 3965246 Part-of: #4961 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 17, 2024
This commit adds indentation to row headers in the pivot table, based on the depth of the groupBy. closes #4961 Task: 3965246 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
[IMP] pivot: add indentation to row headers
This commit adds indentation to row headers in the pivot table, based
on the depth of the groupBy.
[IMP] format: add the handling of repeated character
This commit adds the handling of the
*
asterisk character in the format,which repeats the character that comes after it enough times to fill
the column.
The asterisk is ignored in
cell.formattedValue
, and the character isonly repeated if the
formatValue
helper is given awidth
parameter,which we now do only in the grid renderer.
The commit also adds this new format feature to the accounting format,
to match the behaviour of the other spreadsheet applications.
Task: 3965246
review checklist