Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] charts: handles multiple bars in combo chart #4957

Closed
wants to merge 1 commit into from

Conversation

anhe-odoo
Copy link
Contributor

@anhe-odoo anhe-odoo commented Sep 6, 2024

Task Description

This task adds the possibility to choose which series are bar and line in a combo chart, make the user able to change this for each data series in the design pannel.
When there is no bar series in the set, the first one is always considered as a bar chart, to stay consistent with the previous behavior.

Related Task

  • Task: 4164614

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@anhe-odoo anhe-odoo force-pushed the master-chart-handle_multiple_combo_bars-anhe branch from 885ee75 to f5f67fd Compare September 6, 2024 10:18
@robodoo
Copy link
Collaborator

robodoo commented Sep 6, 2024

Pull request status dashboard

Copy link
Contributor

@hokolomopo hokolomopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a neat little feature 😊

src/helpers/figures/charts/combo_chart.ts Show resolved Hide resolved
src/types/chart/combo_chart.ts Outdated Show resolved Hide resolved
tests/figures/chart/combo_chart_plugin.test.ts Outdated Show resolved Hide resolved
tests/figures/chart/combo_chart_plugin.test.ts Outdated Show resolved Hide resolved
tests/figures/chart/combo_chart_component.test.ts Outdated Show resolved Hide resolved
tests/figures/chart/combo_chart_component.test.ts Outdated Show resolved Hide resolved
tests/figures/chart/combo_chart_component.test.ts Outdated Show resolved Hide resolved
src/helpers/figures/charts/combo_chart.ts Outdated Show resolved Hide resolved
@anhe-odoo anhe-odoo force-pushed the master-chart-handle_multiple_combo_bars-anhe branch 3 times, most recently from 2179682 to dea3e44 Compare September 17, 2024 12:33
@anhe-odoo anhe-odoo force-pushed the master-chart-handle_multiple_combo_bars-anhe branch from dea3e44 to d0b80e5 Compare September 19, 2024 12:09
@LucasLefevre LucasLefevre changed the base branch from master to 18.0 September 30, 2024 07:43
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-targeted to 18.0
robodoo r+

robodoo pushed a commit that referenced this pull request Sep 30, 2024
Task Description

This task adds the possibility to choose which series are bar
and line in a combo chart, make the user able to change this
for each data series in the design pannel.
When there is no bar series in the set, the first one is always
considered as a bar chart, to stay consistent with the previous
behavior.

Related Task

closes #4957

Task: 4164614
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
@robodoo
Copy link
Collaborator

robodoo commented Sep 30, 2024

@anhe-odoo @LucasLefevre staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/build/68902314)

Task Description

This task adds the possibility to choose which series are bar
and line in a combo chart, make the user able to change this
for each data series in the design pannel.
When there is no bar series in the set, the first one is always
considered as a bar chart, to stay consistent with the previous
behavior.

Related Task

Task: 4164614
@anhe-odoo anhe-odoo force-pushed the master-chart-handle_multiple_combo_bars-anhe branch from d0b80e5 to 9d43b69 Compare September 30, 2024 08:55
@LucasLefevre
Copy link
Collaborator

robodoo r+

@robodoo robodoo closed this in 449782a Sep 30, 2024
@fw-bot fw-bot deleted the master-chart-handle_multiple_combo_bars-anhe branch October 14, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants