[FW][FIX] session: avoid concurrent updates #4929
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce (in odoo)
=> non-deterministic concurrent update because we save the thumbnail and we snapshot at the same time.
I'm able to reproduce more when my laptop power setting is on "performance" compared to "balanced"
With this commit
leaveSession
is now asynchronous and returns a promise which resolves after the snapshot was done.It allows to await this promise to trigger other RPC updating the same record.
Task: 4080148
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist
Forward-Port-Of: #4911