Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][PERF] model: export lazily when leaving #4853

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Aug 19, 2024

Description:

Since 7bcff34, the model data is exported every time the spreadsheet is left.
Exporting the data can be slow though and it's actually not needed every time.

With this commit, the data is exported lazily, only when needed.

Task: : 4119536

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4848

Since 7bcff34, the model data is exported every time
the spreadsheet is left.
Exporting the data can be slow though and it's actually not
needed every time.

With this commit, the data is exported lazily, only when
needed.

Task: 4119536
X-original-commit: 9bc489b
@robodoo
Copy link
Collaborator

robodoo commented Aug 19, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Aug 19, 2024

@pro-odoo
Copy link
Collaborator

robodoo r+

robodoo pushed a commit that referenced this pull request Aug 19, 2024
Since 7bcff34, the model data is exported every time
the spreadsheet is left.
Exporting the data can be slow though and it's actually not
needed every time.

With this commit, the data is exported lazily, only when
needed.

closes #4853

Task: 4119536
X-original-commit: 9bc489b
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
@robodoo robodoo closed this Aug 19, 2024
@robodoo robodoo added the 17.5 label Aug 19, 2024
@fw-bot fw-bot deleted the master-17.0-lazy-export-lul-MxtF-fw branch September 2, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants