[FIX] find & replace: remove debounce from store #4847
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The method `updateSearchContent` was debounced inside the f&r store. This does not work as expected, as the re-rendering of the panel was done when calling the `updateSearchContent` method, and not when the debounced function was called and the store state was updated. I'm not sure why it still worked 50% of the time. Task: 4102172
hokolomopo
force-pushed
the
saas-17.2-find-and-replace-debound-adrm
branch
from
168dfce to
ef514fd
Compare
robodoo
pushed a commit
that referenced
this pull request
Aug 22, 2024
The method `updateSearchContent` was debounced inside the f&r store. This does not work as expected, as the re-rendering of the panel was done when calling the `updateSearchContent` method, and not when the debounced function was called and the store state was updated. I'm not sure why it still worked 50% of the time. closes #4847 Task: 4102172 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
14 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The method
updateSearchContentwas debounced inside the f&r store. This does not work as expected, as the re-rendering of the panel was done when calling theupdateSearchContentmethod, and not when the debounced function was called and the store state was updated.I'm not sure why it still worked 50% of the time.
Task: : 4102172
review checklist