Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][REF] plugin cell: use a new command "CLEAR_CELLS" #4831

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Aug 12, 2024

for performance and clarification reasons, groups
the dispatch commands "CLEAR_CELL" with a single
command "CLEAR_CELLS" where possible.

Task : 4095732

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4782

@robodoo
Copy link
Collaborator

robodoo commented Aug 12, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Aug 12, 2024

@laa-odoo @LucasLefevre cherrypicking of pull request #4782 failed.

stdout:

CONFLICT (modify/delete): src/helpers/clipboard/clipboard_cells_state.ts deleted in bee93a46dc3e1c1bbbb87336a6aca5117448228c and modified in a454b43527d8579d0f2a1d29dee886b03335bd1d.  Version a454b43527d8579d0f2a1d29dee886b03335bd1d of src/helpers/clipboard/clipboard_cells_state.ts left in tree.
Auto-merging src/plugins/core/cell.ts
CONFLICT (content): Merge conflict in src/plugins/core/cell.ts
Auto-merging src/plugins/core/merge.ts
Auto-merging src/plugins/core/sheet.ts
Auto-merging src/plugins/ui_feature/data_cleanup.ts
Auto-merging src/plugins/ui_stateful/clipboard.ts
CONFLICT (content): Merge conflict in src/plugins/ui_stateful/clipboard.ts
Auto-merging src/registries/repeat_commands_registry.ts
Auto-merging src/types/commands.ts
Auto-merging tests/repeat_commands_plugin.test.ts
Auto-merging tests/test_helpers/commands_helpers.ts
Auto-merging tests/test_helpers/constants.ts
CONFLICT (content): Merge conflict in tests/test_helpers/constants.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

for performance and clarification reasons, groups
the dispatch commands "CLEAR_CELL" with a single
command "CLEAR_CELLS" where possible.

Task: 4095732
X-original-commit: a6192dd
@rrahir rrahir force-pushed the saas-17.2-17.0-ref-clear_cell-command-laa-cVqR-fw branch from fa2e064 to 0bc4dc9 Compare August 13, 2024 12:47
@rrahir
Copy link
Collaborator

rrahir commented Aug 13, 2024

@robodoo r+

robodoo pushed a commit that referenced this pull request Aug 13, 2024
for performance and clarification reasons, groups
the dispatch commands "CLEAR_CELL" with a single
command "CLEAR_CELLS" where possible.

closes #4831

Task: 4095732
X-original-commit: a6192dd
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo closed this Aug 13, 2024
@fw-bot fw-bot deleted the saas-17.2-17.0-ref-clear_cell-command-laa-cVqR-fw branch August 27, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants