[FW][FIX] parser: parsing empty string throws meaningful error #4830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`parse("")` throws an error like `cannot ready property of undefined`.
With this commit, it throws a user friendly message.
Note that it doesn't cause any (known) real bug, but let's make it more
robust nonetheless.
Task: 0
X-original-commit: 76c0de4
|
|
|
This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
14 tasks
robodoo
pushed a commit
that referenced
this pull request
Aug 12, 2024
`parse("")` throws an error like `cannot ready property of undefined`.
With this commit, it throws a user friendly message.
Note that it doesn't cause any (known) real bug, but let's make it more
robust nonetheless.
closes #4830
Task: 0
X-original-commit: 76c0de4
Signed-off-by: Rémi Rahir (rar) <[email protected]>
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
parse("")throws an error likecannot ready property of undefined.Note that it doesn't cause any (known) real bug, but let's make it more robust nonetheless.
With this commit, it throws a user friendly message.
Task: : TASK_ID
review checklist
Forward-Port-Of: #4827
Forward-Port-Of: #4825