Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] parser: parsing empty string throws meaningful error #4826

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Aug 12, 2024

Description:

parse("") throws an error like cannot ready property of undefined.

Note that it doesn't cause any (known) real bug, but let's make it more robust nonetheless.

With this commit, it throws a user friendly message.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4825

@robodoo
Copy link
Collaborator

robodoo commented Aug 12, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Aug 12, 2024

@LucasLefevre @rrahir cherrypicking of pull request #4825 failed.

stdout:

Auto-merging src/formulas/parser.ts
CONFLICT (content): Merge conflict in src/formulas/parser.ts
Auto-merging tests/formulas/parser.test.ts

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

`parse("")` throws an error like `cannot ready property of undefined`.

With this commit, it throws a user friendly message.

Note that it doesn't cause any (known) real bug, but let's make it more
robust nonetheless.

Task: 0
X-original-commit: bc4057f
@LucasLefevre LucasLefevre force-pushed the 16.0-15.0-parse-empty-string-lul-blCI-fw branch from 96815d7 to 03793a8 Compare August 12, 2024 08:26
Copy link
Collaborator

@LucasLefevre LucasLefevre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Aug 12, 2024
`parse("")` throws an error like `cannot ready property of undefined`.

With this commit, it throws a user friendly message.

Note that it doesn't cause any (known) real bug, but let's make it more
robust nonetheless.

closes #4826

Task: 0
X-original-commit: bc4057f
Signed-off-by: Rémi Rahir (rar) <[email protected]>
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
@robodoo robodoo closed this Aug 12, 2024
@fw-bot fw-bot deleted the 16.0-15.0-parse-empty-string-lul-blCI-fw branch August 26, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants