Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] package: Fix typo in module key #4816

Closed
wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Aug 9, 2024

The filename in the key module from package.json did not match the actual file generated with rollup.

Task: 0

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #4813

The filename in the key `module` from `package.json` did not match
the actual file generated with rollup.

Task: 0
X-original-commit: 9adec36
@robodoo
Copy link
Collaborator

robodoo commented Aug 9, 2024

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Aug 9, 2024

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

robodoo pushed a commit that referenced this pull request Aug 9, 2024
The filename in the key `module` from `package.json` did not match
the actual file generated with rollup.

closes #4816

Task: 0
X-original-commit: 9adec36
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo closed this Aug 9, 2024
@fw-bot
Copy link
Collaborator Author

fw-bot commented Aug 21, 2024

@rrahir @LucasLefevre ancestor PR #4815 has been updated but this PR is merged and can't be updated to match.

You may want or need to manually update any followup PR.

@fw-bot fw-bot deleted the saas-17.1-15.0-fix-esm-typo-rar-NR19-fw branch August 23, 2024 13:46
Topdev97 added a commit to Topdev97/o-spreadsheet that referenced this pull request Nov 18, 2024
The filename in the key `module` from `package.json` did not match
the actual file generated with rollup.

closes odoo/o-spreadsheet#4816

Task: 0
X-original-commit: 9adec36c184967bc06f159e3df4c7233044689a0
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Signed-off-by: Rémi Rahir (rar) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants