[IMP] charts: disable legend for single dataset #4600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
reviewed
Jul 8, 2024
anhe-odoo
force-pushed
the
master-chart-disable_legend-anhe
branch
2 times, most recently
from
be39eee to
1fab50c
Compare
hokolomopo
reviewed
Jul 10, 2024
src/components/side_panel/chart/chart_with_axis/design_panel.xml
Outdated
Show resolved
Hide resolved
anhe-odoo
force-pushed
the
master-chart-disable_legend-anhe
branch
from
1fab50c to
d61e342
Compare
hokolomopo
reviewed
Jul 24, 2024
Task Description When drawing a chart with only one dataset, we are allowed to choose the position of the legend but no legend will appears even after changing the position. This commit aims to fix thie issue, disabling the select box allowing to change the legend position. The chart padding has also been adapted to have more padding when there is no title/legend. Related Task Task: 4028903
anhe-odoo
force-pushed
the
master-chart-disable_legend-anhe
branch
from
d61e342 to
90e1154
Compare
robodoo
pushed a commit
that referenced
this pull request
Jul 29, 2024
Task Description When drawing a chart with only one dataset, we are allowed to choose the position of the legend but no legend will appears even after changing the position. This commit aims to fix thie issue, disabling the select box allowing to change the legend position. The chart padding has also been adapted to have more padding when there is no title/legend. Related Task closes #4600 Task: 4028903 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Description
When drawing a chart with only one dataset, we are allowed to choose the position of the legend but no legend will appears even after changing the position. This commit aims to fix thie issue, disabling the select box allowing to change the legend position.
The chart padding has also been adapted to have more padding when there is no title/legend.
Related Task
review checklist