[IMP] clipboard: preserve cell style and format when copy/pasting cross spreadsheets #4053

Rachico · 2024-04-11T11:47:02Z

[IMP] clipboard: preserve cell style and format when copy/pasting cross spreadsheets

Problem

Before this commit, copying and pasting content cross spreadsheets removes all cell style and format and only keeps cell values. This is because the model clipboard is invalidated from one instance to another.

Solution

This commit solves the issue by adding a new custom type in the os clipboard (application/o-spreadsheet) and using the content saved in this key to re-create the cell style and format in the new spreadsheet.

NOTE: After an assessment of the capabilities and limitations of most modern browsers, here's the bottom line till the date of this commit:

For Google Chrome (and all chromium browsers: Opera, Edge, Brave,...): read/write are supported for custom types; Therefore cross spreadsheet copy/paste works like a charm.

For Safari and Mozilla Firefox: saving custom types in the os clipboard is not supported; Therefore, cross spreadsheet copy/paste does not work.

Task: 3597039

review checklist

robodoo · 2024-04-11T11:47:13Z

Pull request status dashboard.

src/plugins/ui_stateful/clipboard.ts

src/types/commands.ts

src/actions/menu_items_actions.ts

tests/test_helpers/commands_helpers.ts

src/plugins/ui_stateful/clipboard.ts

tests/clipboard/clipboard_plugin.test.ts

tests/test_helpers/commands_helpers.ts

src/helpers/clipboard/navigator_clipboard_wrapper.ts

tests/menus/menu_items_registry.test.ts

src/plugins/ui_stateful/clipboard.ts

src/helpers/range.ts

src/actions/menu_items_actions.ts

src/components/grid/grid.ts

tests/clipboard/clipboard_plugin.test.ts

LucasLefevre

A few more suggestions, otherwise it LGTM 👍 and almost ready to merge :)

src/actions/menu_items_actions.ts

src/clipboard_handlers/cell_clipboard.ts

src/components/grid/grid.ts

src/actions/menu_items_actions.ts

src/helpers/range.ts

src/helpers/ui/paste_interactive.ts

src/plugins/ui_stateful/clipboard.ts

tests/spreadsheet/spreadsheet_component.test.ts

Task: 0 Co-authored-by: Rachico <[email protected]>

Before this commit, copying and pasting content cross spreadsheets removes all cell style and format and only keeps cell values. This is because the model clipboard is different from one instance to another. This commit solves the issue by adding a new custom type in the os clipboard (`application/o-spreadsheet`) and using the content saved in this key to re-create the cell style and format in the new spreadsheet. NOTE: After an assessment of the capabilities and limitations of most modern browsers, here's the bottom line till the date of this commit: For Google Chrome (and all chromium browsers: Opera, Edge, Brave,...): read/write are supported for custom types; Therefore cross spreadsheet copy/paste works like a charm. For Safari and Mozilla Firefox: saving custom types in the os clipboard is not supported; Therefore, cross spreadsheet copy/paste does not work. Task: 3597039

LucasLefevre

I reformatted the commit message to have shorter lines.
A common guideline is: the title should be short (ideally < 50 chars) and all lines in
the message as well (ideally < 80 chars)

robodoo r+ rebase-ff

src/plugins/core/cell.ts

robodoo · 2024-08-05T09:40:58Z

Merge method set to rebase and fast-forward.

Task: 0 Part-of: #4053 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Co-authored-by: Rachico <[email protected]>

Before this commit, copying and pasting content cross spreadsheets removes all cell style and format and only keeps cell values. This is because the model clipboard is different from one instance to another. This commit solves the issue by adding a new custom type in the os clipboard (`application/o-spreadsheet`) and using the content saved in this key to re-create the cell style and format in the new spreadsheet. NOTE: After an assessment of the capabilities and limitations of most modern browsers, here's the bottom line till the date of this commit: For Google Chrome (and all chromium browsers: Opera, Edge, Brave,...): read/write are supported for custom types; Therefore cross spreadsheet copy/paste works like a charm. For Safari and Mozilla Firefox: saving custom types in the os clipboard is not supported; Therefore, cross spreadsheet copy/paste does not work. closes #4053 Task: 3597039 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>

LucasLefevre reviewed Apr 11, 2024

View reviewed changes

src/plugins/ui_stateful/clipboard.ts Outdated Show resolved Hide resolved

src/types/commands.ts Outdated Show resolved Hide resolved

src/types/commands.ts Outdated Show resolved Hide resolved

src/types/commands.ts Outdated Show resolved Hide resolved

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch 5 times, most recently from 7a773c4 to 8f650d2 Compare April 15, 2024 09:43

Rachico changed the title ~~[IMP] Keep cell formatting when copy/pasting data from a spreadsheet to another~~ [IMP] clipboard: keep cell formatting when copy/pasting data from a spreadsheet to another Apr 15, 2024

Rachico changed the title ~~[IMP] clipboard: keep cell formatting when copy/pasting data from a spreadsheet to another~~ [IMP] clipboard: keep cell formatting when copy/pasting cells from a spreadsheet to another Apr 15, 2024

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch 2 times, most recently from 0c59953 to c5c78c4 Compare April 15, 2024 14:21

Rachico marked this pull request as ready for review April 15, 2024 14:21

Rachico changed the title ~~[IMP] clipboard: keep cell formatting when copy/pasting cells from a spreadsheet to another~~ [IMP] clipboard: keep cell formatting when copy/pasting cells from one spreadsheet to another Apr 15, 2024

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch 4 times, most recently from f2bee9d to 4c94ede Compare April 16, 2024 13:24

LucasLefevre reviewed Apr 17, 2024

View reviewed changes

LucasLefevre reviewed Apr 18, 2024

View reviewed changes

src/helpers/clipboard/navigator_clipboard_wrapper.ts Outdated Show resolved Hide resolved

src/helpers/clipboard/navigator_clipboard_wrapper.ts Outdated Show resolved Hide resolved

tests/menus/menu_items_registry.test.ts Outdated Show resolved Hide resolved

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch 5 times, most recently from f9fcdec to b140631 Compare April 26, 2024 10:08

LucasLefevre reviewed Apr 29, 2024

View reviewed changes

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch 2 times, most recently from e32b699 to 069cb8d Compare May 6, 2024 12:01

Rachico requested a review from LucasLefevre May 6, 2024 12:02

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch 2 times, most recently from d659d47 to 50546cf Compare May 8, 2024 08:34

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch 3 times, most recently from 68682e4 to 46b2256 Compare July 11, 2024 13:16

Rachico requested a review from LucasLefevre July 11, 2024 13:27

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch from 46b2256 to 01bb5b3 Compare July 12, 2024 19:45

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch 4 times, most recently from 6230554 to 576d350 Compare July 30, 2024 09:56

LucasLefevre reviewed Jul 30, 2024

View reviewed changes

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch 2 times, most recently from 6843d08 to 78fff77 Compare July 30, 2024 16:31

Rachico requested a review from LucasLefevre July 30, 2024 16:31

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch from 78fff77 to 8560e26 Compare July 31, 2024 08:34

LucasLefevre force-pushed the master-copy-paste-to-other-spreadsheets-mera branch from 8560e26 to e501270 Compare July 31, 2024 11:03

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch 3 times, most recently from 5353598 to e260667 Compare August 1, 2024 11:18

[FIX] clipboard: cut & paste bad expression with references

ae2fa98

Task: 0 Co-authored-by: Rachico <[email protected]>

Rachico force-pushed the master-copy-paste-to-other-spreadsheets-mera branch from e260667 to 1a1fcb7 Compare August 1, 2024 11:23

LucasLefevre force-pushed the master-copy-paste-to-other-spreadsheets-mera branch from 1a1fcb7 to bf4cb25 Compare August 5, 2024 09:38

LucasLefevre approved these changes Aug 5, 2024

View reviewed changes

src/plugins/core/cell.ts Outdated Show resolved Hide resolved

src/plugins/core/cell.ts Outdated Show resolved Hide resolved

robodoo pushed a commit that referenced this pull request Aug 5, 2024

[FIX] clipboard: cut & paste bad expression with references

6b26d71

Task: 0 Part-of: #4053 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Co-authored-by: Rachico <[email protected]>

robodoo temporarily deployed to merge August 5, 2024 09:56 Inactive

robodoo closed this Aug 5, 2024

robodoo added the 17.5 label Aug 5, 2024

fw-bot deleted the master-copy-paste-to-other-spreadsheets-mera branch August 19, 2024 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMP] clipboard: preserve cell style and format when copy/pasting cross spreadsheets #4053

[IMP] clipboard: preserve cell style and format when copy/pasting cross spreadsheets #4053

Rachico commented Apr 11, 2024 •

edited

Loading

robodoo commented Apr 11, 2024

LucasLefevre left a comment

LucasLefevre left a comment

robodoo commented Aug 5, 2024

[IMP] clipboard: preserve cell style and format when copy/pasting cross spreadsheets #4053

[IMP] clipboard: preserve cell style and format when copy/pasting cross spreadsheets #4053

Conversation

Rachico commented Apr 11, 2024 • edited Loading