Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][IMP] spreadsheet: inherit font family #2272

Closed
wants to merge 1 commit into from
Closed

[FW][IMP] spreadsheet: inherit font family #2272

wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 27, 2023

Description

Now spreadsheet inherits the font family from its parent in the DOM.

Odoo task ID : 3000885

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #2247
Forward-Port-Of: #2108

@hokolomopo
[IMP] spreadsheet: inherit font family
e529d91 
Now `spreadsheet` inherits the font family from its parent in the DOM.

Odoo task 3000885

X-original-commit: d773199
@robodoo
Copy link
Collaborator

robodoo commented Mar 27, 2023

Pull request status dashboard.

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 27, 2023

@hokolomopo @rrahir this PR targets master and is the last of the forward-port chain.

To merge the full chain, say

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@hokolomopo
Copy link
Contributor

@fw-bot r+

robodoo pushed a commit that referenced this pull request Mar 27, 2023
@hokolomopo
[IMP] spreadsheet: inherit font family
bf6c3b6 
Now `spreadsheet` inherits the font family from its parent in the DOM.

Odoo task 3000885

closes #2272

X-original-commit: d773199
Signed-off-by: Rémi Rahir (rar) <[email protected]>
Signed-off-by: Minne Adrien (adrm) <[email protected]>
@robodoo robodoo temporarily deployed to merge March 27, 2023 07:06 Inactive
@robodoo robodoo closed this Mar 27, 2023
@robodoo robodoo added the 16.3 label Mar 27, 2023
@fw-bot fw-bot deleted the master-master-parametric-font-family-adrm-mAe6-fw branch April 10, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
16.3 forwardport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fw-bot @robodoo @hokolomopo