-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FW] Bump owl version #2260
Closed
Closed
[FW] Bump owl version #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rrahir @LucasLefevre cherrypicking of pull request #2252 failed. stdout:
stderr:
Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. |
rrahir
force-pushed
the
saas-16.2-16.0-bump-owl-rar-7046-fw
branch
from
March 23, 2023 07:14
52ffb68
to
ce64927
Compare
1. UI tests would sometimes do queries on document but it is more correct to rely on `fixture` as ATM? we cannot ensure that a fixture is alone in the document. Note that this commit only fixes the potentially problematic occurences. Related to point 2. 2. Some tests were nested in describe section that would mount useless components.
rrahir
force-pushed
the
saas-16.2-16.0-bump-owl-rar-7046-fw
branch
from
March 23, 2023 07:24
ce64927
to
53699e8
Compare
catching up to odoo version 2.0.9
@robodoo r+ rebase-ff |
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Mar 23, 2023
1. UI tests would sometimes do queries on document but it is more correct to rely on `fixture` as ATM? we cannot ensure that a fixture is alone in the document. Note that this commit only fixes the potentially problematic occurences. Related to point 2. 2. Some tests were nested in describe section that would mount useless components. Part-of: #2260
robodoo
pushed a commit
that referenced
this pull request
Mar 23, 2023
catching up to odoo version 2.0.9 closes #2260 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Rémi Rahir (rar) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
this PR bumps the version of OWL in o-spreadshset to catch up with its counterpart in odoo: version 2.0.9
One major change (one could argue breaking) is that the property
el
of aRef
is nowundefined
once the component is no longer mounted. This change of behaviour highlighted several issues in our tests setup. Since several of them were addressed in PR #2045, it was decided to backport the said pull request in version 16.0 to ease the transition of owl versions.Odoo task ID : TASK_ID
review checklist
Forward-Port-Of: #2258
Forward-Port-Of: #2252