[FW][FIX] clipboard: don't open composer on firefox #2257
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Ok... that's weird, but not a big deal.
But it gets better:
The composer opens in the same way, but it doesn't support multiline text!
This commit fixes the composer opening and it also makes the edition plugin more robust by removing any carriage return that could slip through.
Additional small fix in the content editable helper, the selection
start
was not clipped if it was greater than the content length.Note: it doesn't happen on Chrome because
ev.data
is null when pasting content. It doesn't correctly implements the spechttps://w3c.github.io/input-events/#dfn-data
opw-3236303
opw : 3236303
review checklist
Forward-Port-Of: #2254
Forward-Port-Of: #2251