Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][IMP] spreadsheet: inherit font family #2246

Closed

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Mar 20, 2023

Description

Now spreadsheet inherits the font family from its parent in the DOM.

Odoo task ID : 3000885

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #2108

Now `spreadsheet` inherits the font family from its parent in the DOM.

Odoo task 3000885

X-original-commit: 93900b4
@robodoo
Copy link
Collaborator

robodoo commented Mar 20, 2023

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 20, 2023

This PR targets saas-16.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Collaborator Author

fw-bot commented Mar 20, 2023

@hokolomopo @rrahir the next pull request (#2247) is in conflict. You can merge the chain up to here by saying

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot fw-bot mentioned this pull request Mar 24, 2023
14 tasks
@rrahir
Copy link
Collaborator

rrahir commented Mar 28, 2023

@fw-bot r+

robodoo pushed a commit that referenced this pull request Mar 28, 2023
Now `spreadsheet` inherits the font family from its parent in the DOM.

Odoo task 3000885

closes #2246

X-original-commit: 93900b4
Signed-off-by: Rémi Rahir (rar) <[email protected]>
@robodoo robodoo temporarily deployed to merge March 28, 2023 07:44 Inactive
@robodoo robodoo closed this Mar 28, 2023
@fw-bot fw-bot deleted the saas-16.1-master-parametric-font-family-adrm-ifh1-fw branch April 11, 2023 07:46
Topdev97 added a commit to Topdev97/o-spreadsheet that referenced this pull request Nov 18, 2024
Now `spreadsheet` inherits the font family from its parent in the DOM.

Odoo task 3000885

closes odoo/o-spreadsheet#2246

X-original-commit: 93900b4222f1180200bf4aa4cf9997dd88d22871
Signed-off-by: Rémi Rahir (rar) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants