[FW][FIX] Top_bar: composer helper menu close #2238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets saas-16.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@aath-odoo @rrahir ci/runbot failed on this forward-port PR |
The composer would not close its assistant when it lost focus, which was confusing, specifically when opening a topbar menu for instance. A proper fix f behaviour would require some refactoring of the edition plugin so in stable, we propose to close the composer when opening a topbar menu. Task: 3076218 X-original-commit: 07aa9f7
aath-odoo
force-pushed
the
saas-16.2-16.0-fix-composer-helper-menu-onblur-aath-Dq0L-fw
branch
from
09d870a to
506be5c
Compare
|
@aath-odoo @rrahir this PR was modified / updated and has become a normal PR. It should be merged the normal way (via @robodoo) |
14 tasks
|
@robodoo r+ |
14 tasks
fw-bot
deleted the
saas-16.2-16.0-fix-composer-helper-menu-onblur-aath-Dq0L-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixed composer helper menu not being closed on clicking topbar menu, resulting to refocus the composer.
Odoo task ID : 3076218
review checklist
Forward-Port-Of: #2111