[FW][FIX] xlsx export: empty string in filtered range #2235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we try to export a sheet that have a data filter, and that in the filtered zone there is a formula evaluating to an empty string, Excel will say that it found an issue when opening the xlsx. That's because in the xlsx we have to put all the values that are not filtered, except for empty values. This was correctly handled for simple empty cells, but not for cells evaluating to an empty string. Odoo task 3231699 X-original-commit: 3cff999
|
This PR targets saas-16.2 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
fw-bot
deleted the
saas-16.2-16.0-xlsx-filter-empty-value-export-adrm-BfwN-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When we try to export a sheet that have a data filter, and that in the filtered zone there is a formula evaluating to an empty string, Excel will say that it found an issue when opening the xlsx.
That's because in the xlsx we have to put all the values that are not filtered, except for empty values. This was correctly handled for simple empty cells, but not for cells evaluating to an empty string.
Odoo task ID : 3231699
review checklist
Forward-Port-Of: #2227
Forward-Port-Of: #2222