[FW][FIX] filters: filter can hide all the visible rows of a sheet #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently possible to use data filters to hide all the rows in a sheet, leaving a buggy sheet with no visible rows. Fixing this is a bit tricky, since the filtered rows are an UI concept, and thus we cannot rely on the allowDispatch of "HIDE_COLUMNS_ROWS" to prevent the user from hiding all the rows. Using allowDispatch isn't possible because the filtered values (and the values of the cells) are different from an user to another. This means that the allowDispatch could return a success for an user, and a failure for the other, leading to a dis-synchronized model state for the 2 user. Fortunately we can fix this by disabling data filters whose header row is hidden (by the user or by another filter). By construction of the filters, it becomes impossible to hide all the rows of a sheet. This may still becomes an issue in the future if we implement something like filters being applied to a column header. In that case, we would need to handle sheets with all their rows hidden. Odoo task 3205608 X-original-commit: 1eee732
|
This PR targets saas-16.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
14 tasks
Topdev97
added a commit
to Topdev97/o-spreadsheet
that referenced
this pull request
Nov 18, 2024
It's currently possible to use data filters to hide all the rows in a sheet, leaving a buggy sheet with no visible rows. Fixing this is a bit tricky, since the filtered rows are an UI concept, and thus we cannot rely on the allowDispatch of "HIDE_COLUMNS_ROWS" to prevent the user from hiding all the rows. Using allowDispatch isn't possible because the filtered values (and the values of the cells) are different from an user to another. This means that the allowDispatch could return a success for an user, and a failure for the other, leading to a dis-synchronized model state for the 2 user. Fortunately we can fix this by disabling data filters whose header row is hidden (by the user or by another filter). By construction of the filters, it becomes impossible to hide all the rows of a sheet. This may still becomes an issue in the future if we implement something like filters being applied to a column header. In that case, we would need to handle sheets with all their rows hidden. Odoo task 3205608 closes odoo/o-spreadsheet#2198 X-original-commit: 1eee732af4cc907dd44cd816dcdc598691d49698 Signed-off-by: Rémi Rahir (rar) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's currently possible to use data filters to hide all the rows in a sheet,
leaving a buggy sheet with no visible rows.
Fixing this is a bit tricky, since the filtered rows are an UI concept, and
thus we cannot rely on the allowDispatch of "HIDE_COLUMNS_ROWS" to prevent
the user from hiding all the rows. Using allowDispatch isn't possible
because the filtered values (and the values of the cells) are different
from an user to another. This means that the allowDispatch could return
a success for an user, and a failure for the other, leading to a
dis-synchronized model state for the 2 user.
Fortunately we can fix this by disabling data filters whose header row is
hidden (by the user or by another filter). By construction of the filters,
it becomes impossible to hide all the rows of a sheet.
This may still becomes an issue in the future if we implement something
like filters being applied to a column header. In that case, we would need
to handle sheets with all their rows hidden.
Odoo task ID : 3205608
review checklist
Forward-Port-Of: #2148