Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF] evaluation: simplify reference evaluation functions #1402

Closed
wants to merge 1 commit into from
Closed

[REF] evaluation: simplify reference evaluation functions #1402

wants to merge 1 commit into from

Conversation

LucasLefevre
Copy link
Collaborator

@LucasLefevre LucasLefevre commented Jun 3, 2022 •
edited by rrahir
Loading

Description:

No need to pass the array of ranges and the index, the compiler can index the array for us.
Also, sheetId is useless since it's already in the range

Odoo task ID : 2877573

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_lt("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@robodoo
Copy link
Collaborator

robodoo commented Jun 3, 2022

Pull request status dashboard.

@LucasLefevre LucasLefevre force-pushed the master-simplify-ref-eval-functions-lul branch from fad9cb5 to 6ba91d7 Compare June 3, 2022 20:14
@LucasLefevre
[REF] evaluation: simplify reference evaluation functions
c7c320c 
No need to pass the array of ranges and the index, just give the range.
Also, sheetId is useless since it's already in the range
@LucasLefevre LucasLefevre force-pushed the master-simplify-ref-eval-functions-lul branch from 6ba91d7 to c7c320c Compare June 3, 2022 20:26
pro-odoo
pro-odoo approved these changes Jun 8, 2022
View reviewed changes
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

@robodoo robodoo closed this in c767758 Jun 8, 2022
@robodoo robodoo closed this Jun 8, 2022
@robodoo robodoo temporarily deployed to merge June 8, 2022 06:00 Inactive
@robodoo robodoo added the 15.5 label Jun 8, 2022
@fw-bot fw-bot deleted the master-simplify-ref-eval-functions-lul branch June 22, 2022 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pro-odoo pro-odoo pro-odoo approved these changes

Assignees
No one assigned
Labels
15.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucasLefevre @robodoo @pro-odoo