[FIX] formatting: do not show escape character

If you want to use double quotes in a string which is part of a formula, you
have to escape it using a backslash (="hello \"world\"")
However, the backslash is shown when displaying the cell content.

closes #3565

Task: 3698283
X-original-commit: 050b3ac
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>

src/helpers/format.ts

@@ -114,6 +114,9 @@ function parseFormat(formatString: Format): InternalFormat {
 export function formatValue(value: CellValue, { format, locale }: LocaleFormat): FormattedValue {
   switch (typeof value) {
     case "string":
+      if (value.includes('\\"')) {
+        return value.replace(/\\"/g, '"');
+      }
       return value;
     case "boolean":
       return value ? "TRUE" : "FALSE";

tests/helpers/format.test.ts

@@ -10,6 +10,18 @@ import { FR_LOCALE } from "./../test_helpers/constants";
 
 const locale = DEFAULT_LOCALE;
 
+describe("formatValue on string", () => {
+  test("apply on regular strings", () => {
+    expect(formatValue("", { locale })).toBe("");
+    expect(formatValue("test", { locale })).toBe("test");
+    expect(formatValue("test", { locale, format: "#,###.0" })).toBe("test");
+  });
+
+  test("apply on strings with escape characters", () => {
+    expect(formatValue('Hello \\"world\\"', { locale })).toBe('Hello "world"');
+  });
+});
+
 describe("formatValue on number", () => {
   test("apply default format ", () => {
     expect(formatValue(1, { locale })).toBe("1");

tests/plugins/cell.test.ts

@@ -106,6 +106,12 @@ describe("getCellText", () => {
     const result = clearCell(model, "A1");
     expect(result).toBeCancelledBecause(CommandResult.NoChanges);
   });
+
+  test("escape character is not display when formatting string", () => {
+    const model = new Model();
+    setCellContent(model, "A1", '="hello \\"world\\""');
+    expect(getEvaluatedCell(model, "A1")?.formattedValue).toBe('hello "world"');
+  });
 });
 
 describe("link cell", () => {