Skip to content

Commit

Permalink
[FIX] sheet: Avoid divergent sheet names in collaborative
Browse files Browse the repository at this point in the history
Similar issue to the one raised in #5010.
If 2 userrs with different languages (i.e. different translation
schemes), importing a sheet data without a name could result in
different outcomes for both users.

Currently, this is not an issue because the sheet data are 'fixed'
upstream by the migration mecanism but this might change/disappear in
the future.

closes #5090

Task: 0
Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
  • Loading branch information
rrahir committed Oct 14, 2024
1 parent ae35d03 commit 4a4399b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/plugins/core/sheet.ts
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ export class SheetPlugin extends CorePlugin<SheetState> implements SheetState {
}

for (let sheetData of data.sheets) {
const name = sheetData.name || _t("Sheet") + (Object.keys(this.sheets).length + 1);
const name = sheetData.name || "Sheet" + (Object.keys(this.sheets).length + 1);
const { colNumber, rowNumber } = this.getImportedSheetSize(sheetData);
const sheet: Sheet = {
id: sheetData.id,
Expand Down

0 comments on commit 4a4399b

Please sign in to comment.