[REV] figure,chart: Prevent destructive creation

Since we did not verify the coherence of the commands payload in the
past, we cannot trust them and cannot rely on it now.

This reverts commit 8746ac1.

Part-of: #2150

src/plugins/core/chart.ts

@@ -153,17 +153,8 @@ export class ChartPlugin extends CorePlugin<ChartState> implements ChartState {
   allowDispatch(cmd: Command) {
     const success: CommandResult = CommandResult.Success;
     switch (cmd.type) {
-      case "CREATE_CHART":
-        return this.checkValidations(
-          cmd,
-          this.chainValidations(
-            this.checkChartDuplicate,
-            this.checkEmptyDataset,
-            this.checkDataset
-          ),
-          this.checkLabelRange
-        );
       case "UPDATE_CHART":
+      case "CREATE_CHART":
         return this.checkValidations(
           cmd,
           this.chainValidations(this.checkEmptyDataset, this.checkDataset),
@@ -540,11 +531,4 @@ export class ChartPlugin extends CorePlugin<ChartState> implements ChartState {
     const invalidLabels = !rangeReference.test(cmd.definition.labelRange || "");
     return invalidLabels ? CommandResult.InvalidLabelRange : CommandResult.Success;
   }
-
-  private checkChartDuplicate(cmd: CreateChartCommand): CommandResult {
-    if (this.chartFigures[cmd.sheetId]?.[cmd.id]) {
-      return CommandResult.DuplicatedChartId;
-    }
-    return CommandResult.Success;
-  }
 }

src/plugins/core/figures.ts

@@ -23,7 +23,7 @@ export class FigurePlugin extends CorePlugin<FigureState> implements FigureState
   allowDispatch(cmd: CoreCommand) {
     switch (cmd.type) {
       case "CREATE_FIGURE":
-        return this.checkFigureDuplicate(cmd.sheetId, cmd.figure.id);
+        return this.checkFigureDuplicate(cmd.figure.id);
       case "UPDATE_FIGURE":
       case "DELETE_FIGURE":
         return this.checkFigureExists(cmd.sheetId, cmd.id);
@@ -95,8 +95,8 @@ export class FigurePlugin extends CorePlugin<FigureState> implements FigureState
     return CommandResult.Success;
   }
 
-  private checkFigureDuplicate(sheetId: UID, figureId: UID): CommandResult {
-    if (this.figures[sheetId]?.[figureId]) {
+  private checkFigureDuplicate(figureId: UID): CommandResult {
+    if (Object.values(this.figures).find((sheet) => sheet?.[figureId])) {
       return CommandResult.DuplicatedFigureId;
     }
     return CommandResult.Success;

src/types/commands.ts

@@ -1068,7 +1068,6 @@ export const enum CommandResult {
   InvalidViewportSize,
   FigureDoesNotExist,
   DuplicatedFigureId,
-  DuplicatedChartId,
 }
 
 export interface CommandHandler<T> {