[FIX] functions: XLOOKUP linear search crashes without lookup values

How to reproduce: - In an empty sheet, write `=XLOOKUP("test",F1:F20,G1:G20,,0,-1)` Task: 4320993 Part-of: #5237 Signed-off-by: Adrien Minne (adrm) <[email protected]> Signed-off-by: Rémi Rahir (rar) <[email protected]>
odoo · Nov 20, 2024 · 183a02d · 183a02d
1 parent aa43928
commit 183a02d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/functions/helpers.ts b/src/functions/helpers.ts
@@ -901,7 +901,9 @@ export function linearSearch<T>(
       return reverseSearch ? numberOfValues - i - 1 : i;
     }
   }
-  return reverseSearch ? numberOfValues - closestMatchIndex - 1 : closestMatchIndex;
+  return reverseSearch && closestMatchIndex !== -1
+    ? numberOfValues - closestMatchIndex - 1
+    : closestMatchIndex;
 }
 
 /**

diff --git a/tests/functions/module_lookup.test.ts b/tests/functions/module_lookup.test.ts
@@ -1319,6 +1319,15 @@ describe("XLOOKUP formula", () => {
       "#,##0[$$]"
     );
   });
+
+  test("Empty lookup range with reverse search mode does not crash", () => {
+    const grid = evaluateGrid({
+      A1: "=XLOOKUP(5, B1:B6, C1:C6, , , -1 )",
+      A2: "=XLOOKUP(5, B1:B6, C1:C6, , , -2 )",
+    });
+    expect(grid.A1).toBe("#N/A");
+    expect(grid.A2).toBe("#N/A");
+  });
 });
 
 describe("INDEX formula", () => {