update starter project #1
Conversation
server.js
Outdated
|
|
||
| app.get('/', (req, res) => { | ||
| // Use req.log (a `pino` instance) to log JSON: | ||
| req.log.info({message: 'Hello from NodeJS Starter Application!'}); |
server.js
Outdated
| app.get('/', (req, res) => { | ||
| // Use req.log (a `pino` instance) to log JSON: | ||
| req.log.info({message: 'Hello from NodeJS Starter Application!'}); | ||
| res.send('Hello from NodeJS Starter Application!'); |
.vscode/launch.json
Outdated
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
Is this vscode specific metadata file which has environment specific port number info supposed to be part of the project?
There was a problem hiding this comment.
We had this file in the Appsody nodejs templates, we thought it might be easier for the user as they wouldn't have to create it themselves. But i do see where you are coming from and we should keep it uniform across all stack starter projects so we've removed it
There was a problem hiding this comment.
This is interesting one.. User will need to know reoteRoot path to eb able to setup this themselves.
@elsony do we document this somewhere today? I remember there was a field added to 2.0 spec for pointing to stack documentation. Should we look to use that for capturing such info?
There was a problem hiding this comment.
The attach config doesn't actually require the remoteRoot path, it is enough to give it the correct port, I was just trying to be "helpful". For example, the following debugging config also works for me:
"version": "0.2.0",
"configurations": [
{
"type": "node",
"request": "attach",
"name": "Attach Program",
"skipFiles": [
"<node_internals>/**"
],
"port": 5858,
}
]
}
There was a problem hiding this comment.
That config is largely generated by vscode, I just changed the request from "launch" to "attach" and added the port
There was a problem hiding this comment.
@neeraj-laad For your question on doc, any stack/devfile specific doc should go to the website under the metadata on a devfile. For info specific to the starter project, it should go to the README file in the project.
This PR updates the starter project to use the best practices as discussed with the Node team