Fix stripped binaries support #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added a commit
to honeycombio/opentelemetry-go-instrumentation
that referenced
this pull request
Apr 25, 2023
MrAlias
added a commit
to open-telemetry/opentelemetry-go-instrumentation
that referenced
this pull request
May 2, 2023
* Add ARM64 Support Ported from odigos-io/opentelemetry-go-instrumentation#53 Co-authored-by: Eden Federman <[email protected]> * update net/http probe to get args from ctx instead of goroutine * fix c file formatting * more c file formatting tidy * get http header ctx pointer for net/http instrumentation * switch back to goroutine * set bpf2go target as bpfel * revert bpf2go target to $TARGET * remove generated probe go files * set TARGET in build workflow to amd64 * add default docker image name to makefile * remove TARGET and IMG env vars in build workflow * set TARGETARCH in build workflow * tidy up build workflow * update go generate to use set targets directly * add qemu * lets see what happens with buildarch * try buildx * try buildx * testing if we need buildx setup step * remove --no-cache option * switch back to specific eBPF arch targets * tidy up docker/make files * set default target as amd64 * readd buildx * fix buildx arg * fix image name * wait for longer for e2e pods * Revert "wait for longer for e2e pods" This reverts commit 2ef3b6e. * apply fix for instrumenting stripped binaries ported from: odigos-io/opentelemetry-go-instrumentation#56 * Revert "apply fix for instrumenting stripped binaries" This reverts commit 5d58216. * use $TARGET for gin bpf2cmd * update ptrace_linux_arm * add changelog entry * extend get_goroutine to work with go <1.17 * add missing licese files * fix bad merge in Makefile * remove unnessary additional funcname for net/http instrumentor * update bpf2go generate commands to use both arm and amd * Update changelog entry Co-authored-by: Tyler Yahn <[email protected]> * re-add comments to pt_regs struct * add build guards to findReturnInstructions arch files * unexport error const * separate imports * update mapSize description * Fix changelog entry Co-authored-by: Tyler Yahn <[email protected]> --------- Co-authored-by: Eden Federman <[email protected]> Co-authored-by: Purvi Kanal <[email protected]> Co-authored-by: Robb Kidd <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that caused stripped Go applications (compiled with
-ldflags '-w -s') to not be instrumented.