feat: Addition of ShouldInstrument for instrumenting Nginx master only #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yodigos
changed the title
yodigos
commented
Sep 16, 2024
odiglet/pkg/ebpf/director.go
Outdated
| @@ -103,6 +105,10 @@ type EbpfDirector[T OtelEbpfSdk] struct { | |||
| client client.Client | |||
| } | |||
|
|
|||
| func (d *EbpfDirector[T]) ShouldInstrument(ctx context.Context, id int, details []process.Details) bool { | |||
There was a problem hiding this comment.
Removing ctx - not necessary
blumamir
approved these changes
Sep 17, 2024
odiglet/pkg/ebpf/director.go
Outdated
| @@ -44,6 +45,7 @@ type Director interface { | |||
| // TODO: once all our implementation move to this function we can rename it to ApplyInstrumentationConfig, | |||
| // currently that name is reserved for the old API until it is removed. | |||
| ApplyInstrumentationConfiguration(ctx context.Context, workload *workload.PodWorkload, instrumentationConfig *odigosv1.InstrumentationConfig) error | |||
| ShouldInstrument(ctx context.Context, id int, details []process.Details) bool | |||
There was a problem hiding this comment.
id can mean so many things. better to call it pid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.