Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update http route #1485

Merged
merged 11 commits into from
Sep 5, 2024
Merged

Conversation

dovzhikova
Copy link
Contributor

No description provided.

### HTTP Clients

- [`net/http`](https://pkg.go.dev/net/http) go standard library for http server and client
<Warning>Please note that in order for the `http.route` parameter to be properly extracted by Go auto instrumentation,
you should use Go 1.22 or above and declare a template handler as described in [this article](https://go.dev/blog/routing-enhancements).</Warning>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added only for the server (not the client)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, thanks for the heads up, updating it

@dovzhikova dovzhikova closed this Sep 5, 2024
@dovzhikova dovzhikova reopened this Sep 5, 2024
@blumamir blumamir merged commit b1594fd into odigos-io:main Sep 5, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants