feat: NGINX Version #1462
Merged
feat: NGINX Version #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edeNFed
reviewed
Aug 25, 2024
RonFed
reviewed
Aug 25, 2024
RonFed
reviewed
Aug 28, 2024
| @@ -119,10 +120,15 @@ func runtimeInspection(pods []corev1.Pod, ignoredContainers []string) ([]odigosv | |||
| } | |||
| } | |||
|
|
|||
| runtimeVersion := "" | |||
There was a problem hiding this comment.
Suggested change
| runtimeVersion := "" | |
| var runtimeVersion string |
RonFed
reviewed
Aug 28, 2024
|
|
||
| func (g *GolangInspector) GetRuntimeVersion(p *process.Details, containerURL string) *version.Version { | ||
| file := fmt.Sprintf("/proc/%d/exe", p.ProcessID) | ||
| buildInfo, err := buildinfo.ReadFile(file) |
There was a problem hiding this comment.
nit: We are calling ReadFile twice for each Go process, if it is possible to reuse the buildInfo from the Inspect function it will be better
RonFed
reviewed
Aug 28, 2024
| return programLanguageDetails, true | ||
| func (j *JavaInspector) GetRuntimeVersion(proc *process.Details, containerURL string) *version.Version { | ||
| if value, exists := proc.GetDetailedEnvsValue(process.JavaVersionConst); exists { | ||
| re := regexp.MustCompile(JavaVersionRegex) |
There was a problem hiding this comment.
define as a global const, avoiding re-compiliong the regex each time
RonFed
reviewed
Aug 28, 2024
| return "", nil | ||
| } | ||
|
|
||
| re := regexp.MustCompile(NginxVersionRegex) |
There was a problem hiding this comment.
Same as the comment for the other regex - use as a const
RonFed
reviewed
Aug 30, 2024
| } | ||
| match := re.FindStringSubmatch(buildInfo.GoVersion) |
There was a problem hiding this comment.
I'm not sure why we need this regex here. The buildinfo package is an official go package which should provide a valid go version if one exists.
RonFed
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.