[GEN-1753]: proper English for "running instance(s)" (#1800)

Co-authored-by: Alon Braymok <[email protected]> Co-authored-by: Tamir David <[email protected]> Co-authored-by: Tamir David <[email protected]> Co-authored-by: Amir Blum <[email protected]> Co-authored-by: Ron Federman <[email protected]> Co-authored-by: yodigos <[email protected]> Co-authored-by: Mike Dame <[email protected]> Co-authored-by: alonbraymok <[email protected]> Co-authored-by: Daria Dovzhikova <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Eden Federman <[email protected]>
odigos-io · Nov 20, 2024 · e48b1ca · e48b1ca
1 parent f1dbca5
commit e48b1ca
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...ources/choose-sources/choose-sources-body/choose-sources-body-fast/sources-list/index.tsx b/...ources/choose-sources/choose-sources-body/choose-sources-body-fast/sources-list/index.tsx
@@ -125,7 +125,7 @@ export const SourcesList: React.FC<Props> = ({
         const selected = selectedSources[namespace] || [];
         const futureApps = selectedFutureApps[namespace] || false;
 
-        const namespacePassesFilters = (!searchText || namespace.toLowerCase().includes(searchText)) && (!showSelectedOnly || !!selected.length);
+        const namespacePassesFilters = !searchText || namespace.toLowerCase().includes(searchText);
         if (!namespacePassesFilters) return null;
 
         const isNamespaceSelected = selectedNamespace === namespace && !selectAllForNamespace;
@@ -169,7 +169,7 @@ export const SourcesList: React.FC<Props> = ({
                           <Checkbox initialValue={isSourceSelected} onChange={() => onSelectSource(source, namespace)} />
                           <Text>{source.name}</Text>
                           <Text opacity={0.8} size={10}>
-                            {source.numberOfInstances} running instances · {source.kind}
+                            {source.numberOfInstances} running instance{source.numberOfInstances !== 1 && 's'} · {source.kind}
                           </Text>
                         </FlexRow>
                       </SourceItem>

diff --git a/...rces/choose-sources/choose-sources-body/choose-sources-body-simple/sources-list/index.tsx b/...rces/choose-sources/choose-sources-body/choose-sources-body-simple/sources-list/index.tsx
@@ -108,7 +108,7 @@ export const SourcesList: React.FC<Props> = ({
               <TextWrapper>
                 <Text>{source.name}</Text>
                 <Text opacity={0.8} size={10}>
-                  {source.numberOfInstances} running instances · {source.kind}
+                  {source.numberOfInstances} running instance{source.numberOfInstances !== 1 && 's'} · {source.kind}
                 </Text>
               </TextWrapper>
             </ListItemContent>