unshare: use by default accountType User #771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #747. By default use accountType User, as is done with share, so that users can easily do things like ```shell $ drive unshare -emails [email protected] -id some_id ``` instead of getting back a cryptic error ```shell no matches found! ``` and the common assumptions will work without them having to know the entire setup of share and unshare. I too found this confusing and had to step back a little to figure out that previously the accountTypes were never set hence the loop that runs through each file never runs. This change also ensures that if errors were encountered entirely errors, without any successful shares/unshares, we won't give back the previously cryptic and not useful error of ```shell no matches found! ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #747.
By default use accountType User, as is done with share,
so that users can easily do things like
instead of getting back a cryptic error
no matches found!and the common assumptions will work without them
having to know the entire setup of share and unshare.
I too found this confusing and had to step back a little
to figure out that previously the accountTypes were
never set hence the loop that runs through each file
never runs.
This change also ensures that if errors were encountered entirely
errors, without any successful shares/unshares, we won't give back
the previously cryptic and not useful error of
no matches found!