sort: fixed sorters to be split by comma #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #714. Sort attributes passed in from the commandline are csv values e.g ```shell $ drive list -sort name_r,modtime ``` The bug previously was that these values were actually never getting split by comma values, in cmd/drive/main. This CL ensures that we do the necessary splitting and whitespace trimming before we make the sorters. It also updates the CLI doc on sort: * Before ```shell $ drive list -sort -sort string sort items in the order * md5. * name. * size. * type. * version ``` * After ```shell $ drive list -sort -sort string sort items by a combination of attributes * modtime. * md5. * name. * size. * type. * version ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #714.
Sort attributes passed in from the commandline are csv values e.g
The bug previously was that these values were actually never getting
split by comma values, in cmd/drive/main. This CL ensures that we
do the necessary splitting and whitespace trimming before we
make the sorters.
It also updates the CLI doc on sort:
$ drive list -sort -sort string sort items in the order * md5. * name. * size. * type. * version$ drive list -sort -sort string sort items by a combination of attributes * modtime. * md5. * name. * size. * type. * version