pull/export: fixed ppt vs pptx regex ambiguity #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #583. Updates #551. Fixes an ambiguity with the regexes for `ppt` and `pptx`. The problem was that `ppt` and `pptx` are unterminated regex-wise so `pptx` would get matched as `ppt` and then undeterministically also matched as `pptx`. This mean that `pptx` would give two different mimeTypes ie ```json "ppt": "application/vnd.ms-powerpoint", "pptx": "application/vnd.openxmlformats-officedocument.presentationml.presentation" ``` The fix is to terminate them as `ppt$` and `pptx$` to properly differentiate between the two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #583.
Updates #551.
Fixes an ambiguity with the regexes for
pptandpptx.The problem was that
pptandpptxare unterminated regex-wiseso
pptxwould get matched aspptand then undeterministicallyalso matched as
pptx.This mean that
pptxwould give two different mimeTypes ieThe fix is to terminate them as
ppt$andpptx$to properlydifferentiate between the two.