touch: fixed up premature force exit on nil elem #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes up a bug in which while multiplexing over the channels and looking for channels that had been drained, legacy select code still had a forced `nil` emission at a deferred statement. However, once a channel has been drained, any attempt to read from it will also return `nil`. Coupling this knowledge with a recursive traversal of children, `nil` was being added prematurely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #442 by fixing up a bug in which while multiplexing over
the channels and looking for channels that had been drained,
legacy select code still had a forced
nilemission at a deferredstatement. However, once a channel has been drained, any attempt to
read from it will also return
nil. Coupling this knowledge witha recursive traversal of children,
nilwas being added prematurely.It also refactors the code used by the plain Touch and TouchByMatch
.
Before
After