Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"file does not exist" when pushing/pulling #677

Closed
dconathan opened this issue Jul 3, 2016 · 6 comments
Closed

"file does not exist" when pushing/pulling #677

dconathan opened this issue Jul 3, 2016 · 6 comments
Labels
bug regression

Comments

@dconathan
Copy link

Sorry if I'm missing something obvious, but I can't get drive push and drive pull to work. I can drive rename, drive mv, drive stat files and see the changes reflect on my google drive, but any command involving push or pull gives me an file does not exist error. e.g.

$ cd ~/drive
$ echo "hello" > hello.txt
$ drive push
file does not exist 
$ drive pull
file does not exist
@odeke-em
Copy link
Owner

odeke-em commented Jul 3, 2016

Hello there @dconathan, thank you for the report and welcome to drive.

What does drive version say?

@odeke-em
Copy link
Owner

odeke-em commented Jul 3, 2016

@dconathan I think I identified what went wrong, I screwed something up early this morning in this CL 2a5875f. Fixing it right now :)

@dconathan
Copy link
Author

Oh yeah, should've mentioned I'm using the Arch build from the AUR, though I was getting the same behavior when building using go get as per the readme...

$ drive version
drive version: 0.3.7
Commit Hash: '2a5875f5e0ff464c5ca244a023b79417d3e7ef53'
Go Version: go1.6.2
OS: linux/amd64
BuildTime: 2016-07-03 12:34:48.238438849 -0500 CDT

odeke-em added a commit that referenced this issue Jul 3, 2016
@odeke-em
rc: fix err variable reuse
2104310 
In PR #676,
I touched up the signature and content for function
`JSONStringifySiftedCLITags` to not use named return values.
However, I changed the error check from `ResourceMappings`
to just be `err`. The first check ensures that either a file
exists or doesn't exist. Reusing that variable at the end of
the function meant that any previous error checks for rc paths
that didn't exist were being returned and this would send
back os.ErrNotExist yet the intention of the function
is to digest this error as a check and not as a return value.

Fixes #677.
@odeke-em odeke-em mentioned this issue Jul 3, 2016
Merged
@odeke-em
Copy link
Owner

odeke-em commented Jul 3, 2016

Thank you very much @dconathan for reporting this issue. I fixed it with PR #678. Please get the latest code and the problem should be gone.

@dconathan
Copy link
Author

Indeed fixed. Thanks @odeke-em keep up the good work 👍

@odeke-em
Copy link
Owner

odeke-em commented Jul 3, 2016

Thank you 🙏🏾! Please don't hesitate to reach out in case of any issues or questions.

@odeke-em odeke-em mentioned this issue Jul 3, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odeke-em @dconathan