Add support for local() and data-URIs in font previews. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: Hotfix nested groups bug with undefined groups.
jgerigmeyer
commented
Jan 15, 2018
| /// The font-formats that we want to import | ||
| /// | ||
| /// @group config-fonts | ||
| $font-formats: 'woff' 'ttf'; |
There was a problem hiding this comment.
Since I removed this, not sure if we need to add it back in to the webfont Sass maps?
There was a problem hiding this comment.
We're not using any imported fonts, so this is fine.
jgerigmeyer
commented
Jan 15, 2018
| <div data-specimen="aa">Aa</div> | ||
| <div data-specimen="lorem">{{ lorem('alpha') }}</div> | ||
| </div> | ||
| {% macro specimen_variant(variant, data) %} |
There was a problem hiding this comment.
The JS was already doing all this logic, so I didn't see a reason to duplicate it in the templates any longer.
* master: fix internal links Add links to jsonfile config where relevant upgrade deps Hotfix: Warn if custom annotation used in prose block with `key` arg.
* master: changelog compile Fix string-encoding and quote-escaping
* master: Release v1.1.0
|
@mirisuzanne I think this is all finished, ready for final review/merge. In the process of testing it I discovered a related bug in SassDoc that breaks documenting data-uris (#254), but I think we can merge/release this in any case. |
mirisuzanne
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173.
Fixes #197.
Fixes #254.
@mirisuzanne Okay, I think the Herman side of this is done. Might need a few adjustments once you've finished the accoutrement-type updates.
One question I wasn't sure about... I removed the
$font-formatsglobal setting. I added a newformatskey to all the local/embedded-font Sass maps, but I wasn't sure if it was also required on the webfonts.