Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nested /// in SassDoc comments. #220

Merged
merged 3 commits into from
Dec 8, 2017
Merged

Allow nested /// in SassDoc comments. #220

merged 3 commits into from
Dec 8, 2017

Conversation

jgerigmeyer
Copy link
Member

Fixes #212.

@jgerigmeyer jgerigmeyer mentioned this pull request Dec 6, 2017
Closed
@jgerigmeyer
Copy link
Member Author

Note: If we merge this, it allows us to use /// in Herman comments internally, but it won't allow users of Herman to do the same unless they use our fork of CDocParser, or our PR gets merged in there.

@mirisuzanne
Copy link
Member

Is there a way to do it already with a escape character breaking up the ///? I assume maybe not, since it generally happens in per-formated blocks?

@jgerigmeyer
Copy link
Member Author

No, there's not a way to manually escape characters. I asked about adding that to SassDoc in the issue I filed there.

@jgerigmeyer
Merge branch 'master' into allow-nested-comments
d32aa35 
* master:
  doc fix
  Upgrade dependencies.
@jgerigmeyer jgerigmeyer merged commit 865838c into master Dec 8, 2017
@jgerigmeyer jgerigmeyer deleted the allow-nested-comments branch December 8, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlonk wlonk wlonk approved these changes

@mirisuzanne mirisuzanne mirisuzanne approved these changes

@davisagli davisagli Awaiting requested review from davisagli

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgerigmeyer @mirisuzanne @wlonk