DO NOT MERGE: Remove vendored dependencies #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcgilchrist
force-pushed
the
solver-ci
branch
2 times, most recently
from
a257c60
to
2e0695f
Compare
tmcgilchrist
force-pushed
the
solver-ci
branch
2 times, most recently
from
ffc1d16
to
bea6325
Compare
moyodiallo
force-pushed
the
solver-ci
branch
3 times, most recently
from
348c2a1
to
18edf3b
Compare
|
Why not merge this? CI is (mostly) passing, so it seems these aren't needed at all. |
|
I've made an updated version of this at #68. |
benmandrew
force-pushed
the
solver-ci
branch
2 times, most recently
from
526aaf3
to
e18b21c
Compare
Solver-service is going to be vendored by ocaml-ci and ocaml-multicore-ci, deleting pin-depends make it easy to maintain by having a branch that does not have the vendored repos. And that branch is going to be vendored by ocaml-ci and ocaml-multicore-ci to avoid conflict.
|
@talex5 if we don't need the submodule vendoring (in ocaml-ci) we could get rid of this branch. Ideally when we need to consume this from ocaml-ci we only want the capnp generated API package. |
|
There aren't any submodules at the moment (they were removed in #68) - this PR is now just removing the left-over (note: there's also the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working around this bug in Dune.
Originally raised as ocaml/dune#6577