Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the exotic architecture docker references #134

Closed
wants to merge 3 commits into from

Conversation

dra27
Copy link
Collaborator

@dra27 dra27 commented Dec 17, 2022

Alternate for #133 - it's not that they're not pushed anymore, they're not multiarch on older versions.

@dra27
Copy link
Collaborator Author

dra27 commented Dec 17, 2022

Last commit tested locally on an arm64 box, and it does indeed fix a long-standing problem with the Dockerfiles - for the 32-bit (arm and i386) they were not specifying the platform+personality for the second (main) part of the build so this only worked when we used a non-multiarch image. This if course didn't affect ppl64/s390x (modulo the problem with Debian 10) because there's only one image in the multiarch which they can run.

@dra27
Copy link
Collaborator Author

dra27 commented Dec 17, 2022

The tags are now pushing from docker-base-images, but once that's correct I'll merge this and update them again.

@avsm
Copy link
Member

avsm commented Dec 17, 2022

Be a little careful on the multi-platform builders, as Docker had some unexpected caching behaviour in older releases that may still linger. Specifically, --platform may sometimes be ignored: docker/cli#2590

This should now be fixed, but also need to look at docker/buildx#844 to make sure it isn't an issue. We should be entirely manifest-based now, so I hope it isn't a problem.

@dra27
Copy link
Collaborator Author

dra27 commented Dec 17, 2022

Ta: let's definitely leave testing the last commit on the base image builder until 5.0 is completely deployed, then! The code needs reviewing regardless.

At various points these get merged into Debian's multiarch - prior to
that they were unofficial ports.
--platform doesn't appear to be working correctly
@dra27
Copy link
Collaborator Author

dra27 commented Jan 5, 2023

Fully tested on docker-base-images now, and it seems to be working correctly

MisterDA added a commit that referenced this pull request Jan 18, 2023
@MisterDA
Copy link
Contributor

Merged as of 60eb31d with a dune fmt fix, thanks!

@MisterDA MisterDA closed this Jan 18, 2023
MisterDA added a commit to MisterDA/opam-repository that referenced this pull request Mar 23, 2023
CHANGES:

- Install system packages required by OCaml in the ocaml stage,
  starting with OCaml 5.1 and libzstd.
  (@MisterDA ocurrent/ocaml-dockerfile#149, review by @kit-ty-kate)
- Add OracleLinux 9. (@MisterDA ocurrent/ocaml-dockerfile#155)
- Optimize and fix Linux package install.
  (@MisterDA ocurrent/ocaml-dockerfile#147, ocurrent/ocaml-dockerfile#151, ocurrent/ocaml-dockerfile#153, ocurrent/ocaml-dockerfile#154, review by @kit-ty-kate)
- Switch to ocaml-opam/opam-repository-mingw#sunset for Windows images. (@MisterDA ocurrent/ocaml-dockerfile#152)
- Use DockerHub user risvc64/ubuntu. (@MisterDA, ocurrent/ocaml-dockerfile#150)
- Various LCU Updates (@mtelvers ocurrent/ocaml-dockerfile#144 ocurrent/ocaml-dockerfile#136 ocurrent/ocaml-dockerfile#135)
- Support mounts, networks, and security parameters in RUN
  commands, add buildkit_syntax helper function.
  (@MisterDA, @edwintorok, ocurrent/ocaml-dockerfile#137, ocurrent/ocaml-dockerfile#139, review by @edwintorok)
- Build and install opam master from source in Windows images.
  (@MisterDA ocurrent/ocaml-dockerfile#140, ocurrent/ocaml-dockerfile#142, ocurrent/ocaml-dockerfile#143)
- Include the ocaml-beta-repository in the images. (@kit-ty-kate ocurrent/ocaml-dockerfile#132, review by @MisterDA)
- Add OpenSUSE 15.4, deprecate OpenSUSE 15.3. (@MisterDA ocurrent/ocaml-dockerfile#138)
- Update to bubblewrap 0.8.0. (@MisterDA ocurrent/ocaml-dockerfile#131 ocurrent/ocaml-dockerfile#148)
- Add Alpine 3.17 (3.16 is now tier 2 and 3.15 is deprecated). Remove
  libexecinfo-dev from the list of apk packages as it is no longer
  available. Its symbols are only used in OCaml's self tests.
  (@MisterDA ocurrent/ocaml-dockerfile#129, ocurrent/ocaml-dockerfile#130)
- Fix location of Debian exotic architecture images (@dra27 ocurrent/ocaml-dockerfile#134)
- Fix passing of --platform to all stages of the Dockerfiles (@dra27 ocurrent/ocaml-dockerfile#134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants