Fix x32_86bit job caused by capnproto #894
Conversation
|
Hi! I don't understand how since this PR is unmerged, but it seems to affect CI for us. Our test on debian x86_32 fails due to test failures in capnproto. We don't (transitively) depend on capnproto so it isn't something that should be built. Furthermore, the Dockerfile commands match exactly with this PR. |
You're right, good point. I'll fix it by testing against the dependencies. Thks. |
I deployed it by merging it to the live-engine branch in order to test it before merging it on master branch. |
Ah good, I am relieved to hear this. For a few minutes I was worried any latest commit or PR was used to build the docker image(!) |
There are projects that not depend to capnproto.
|
Thanks for that report, I deployed the fix and It's working. https://ocaml.ci.dev/github/robur-coop/miragevpn/commit/c2dc140344a1d971de7f8e1b042822b2109c39ed. |
|
@moyodiallo can this be merged? |
Not yet, this PR needs some further discussion with @tmcgilchrist. |
|
After a discussion with @tmcgilchrist, it is preferable to not add patched system libraries in the CI. So this PR is replaced by #902. |
|
This won't be merged. |
|
Hi this seems to be back and making unrelated builds fail :( |
Would you like give a link ? |
|
Sorry the there is wrong deployment, I will fixed that. The master branch is free from this error. |
|
After verification and new deployment without this fix, the error wasn't coming from this. This is related to #914. |
|
Well it is still building capnproto in the build I posted above even if it
is unrelated to the package being built.
|
This is a temporary fix, it may take time to have new release of Debian following bookworm, that fixes capnproto.
Issue related to mirage/capnp-rpc#273.
And a PR is addressed to capnproto capnproto/capnproto#1824