Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry unmount on macOS #192

Closed
wants to merge 1 commit into from
Closed

Conversation

mtelvers
Copy link
Member

@mtelvers mtelvers commented Oct 1, 2024

This may look like a lot of changes, but really, it's just a single line. The new behaviour will now retry the unmount on failure with the addition of the -f flag.

Os.sudo [ "zfs"; "unmount"; "obuilder/result" ]

to

Macos.sudo_fallback [ "zfs"; "unmount"; "obuilder/result" ] [ "zfs"; "unmount"; "-f"; "obuilder/result" ] ~uid:t.uid

Addresses ocurrent/ocaml-ci#975

Copy link
Contributor

@shonfeder shonfeder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice clean fix and diagnosis.

@MisterDA
Copy link
Contributor

For me sudo_fallback sounds like the function will try something once, then if it fails try something else in sudo mode. What about adding a ?fallback argument to the sudo function?

@mtelvers
Copy link
Member Author

Yes, I ditched this in favour of #193.

@mtelvers mtelvers closed this Oct 10, 2024
@mtelvers mtelvers deleted the retry-unmount branch October 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants