Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(payloads): add code scanning examples #371

Merged
merged 12 commits into from
Feb 25, 2021

Conversation

pholleran
Copy link
Contributor

This PR adds payload examples for the following code scanning webhooks:

  • fixed
  • closed_by_user
  • created

@gr2m gr2m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 13, 2021
@gr2m
Copy link
Contributor

gr2m commented Feb 13, 2021

The schema needs to be updated. The "enterprise" property is currently not defined for the code_scanning_alert event

  {
    keyword: 'additionalProperties',
    dataPath: '',
    schemaPath: '#/additionalProperties',
    params: { additionalProperty: 'enterprise' },
    message: 'should NOT have additional properties'
  }

@wolfy1339
Copy link
Member

We only have examples from GitHub, and not GHES, which is why the "enterprise" property isn't defined in the schemas.

I think the "enterprise" property should be dropped for now and we can add it to all the schemas in a follow up issue

wolfy1339 added a commit that referenced this pull request Feb 16, 2021
Taken from payload examples in #371
@wolfy1339 wolfy1339 force-pushed the add-code-scanning-examples branch from 585b06d to 9875f5a Compare February 21, 2021 18:53
@wolfy1339 wolfy1339 added the Status: Blocked Some technical or requirement is blocking the issue label Feb 21, 2021
@wolfy1339
Copy link
Member

All is good to go (mostly). Waiting on #379 before this can go any further

@wolfy1339 wolfy1339 changed the title add code scanning examples 🚧 add code scanning examples Feb 21, 2021
@wolfy1339 wolfy1339 removed the Status: Blocked Some technical or requirement is blocking the issue label Feb 25, 2021
@wolfy1339 wolfy1339 changed the title 🚧 add code scanning examples chore(payloads): add code scanning examples Feb 25, 2021
@wolfy1339 wolfy1339 merged commit 8b38156 into octokit:master Feb 25, 2021
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 3.62.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

wolfy1339 added a commit that referenced this pull request Jun 4, 2021
Taken from payload examples in #371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants